| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1231409610.5539.7.camel@brick> Date: Thu, 08 Jan 2009 02:13:30 -0800 From: Harvey Harrison <harvey.harrison@...il.com> To: Pekka Enberg <penberg@...helsinki.fi> Cc: Greg Kroah-Hartman <greg@...ah.com>, Pavel Machek <pavel@...e.cz>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/3] w35und: Move ETH_LENGTH_OF_ADDRESS to wbhal_s.h On Thu, 2009-01-08 at 11:56 +0200, Pekka Enberg wrote: > On Thu, 2009-01-08 at 01:46 -0800, Harvey Harrison wrote: > > On Thu, 2009-01-08 at 11:30 +0200, Pekka J Enberg wrote: > > > From: Pekka Enberg <penberg@...helsinki.fi> > > > > > > +#define ETH_LENGTH_OF_ADDRESS 6 > > > > Or just use ETH_ALEN like the rest of the kernel and drop this guy. > > Even better, thanks Harvey! Greg, please use this one instead. The rest > of the series is unaffected by the changes in this patch. > > >From c849ed5b5e68953a72f8dc43066513f118822f94 Mon Sep 17 00:00:00 2001 > From: Pekka Enberg <penberg@...helsinki.fi> > Date: Thu, 8 Jan 2009 11:10:06 +0200 > Subject: [PATCH] w35und: convert code to use ETH_ALEN > > As suggested by Harvey Harrison, convert driver to use ETH_ALEN and kill a > private macro from common.h that is used for the same thing. Untested, but obviously ACK the approach :-) Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists