linux-kernel - Re: [PATCH 2/3] Driver for user access to internal clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8447d6730901080612r4a15a57k7d8621a7fd29b43b@mail.gmail.com>
Date:	Thu, 8 Jan 2009 15:12:57 +0100
From:	"Davide Rizzo" <elpa.rizzo@...il.com>
To:	"Ben Dooks" <ben-linux@...ff.org>
Cc:	linux-kernel@...r.kernel.org, hjk@...utronix.de, gregkh@...e.de
Subject: Re: [PATCH 2/3] Driver for user access to internal clocks

> you've borken the const of the clk_get() call. I think that
> this is either something that the caller needs to deal with
> as all the drivers will be passing a 'dev' structure in to
> help identify common clocks.
>
As I modified it the clk_get() function it should be compatible with
the past, simply now it recognizes ALSO the format clkname.X to allow
a generic driver to have access to all clocks.
The other way to achieve this is to simulate a specific id in a fake
dev parameter, but it's awful.
For the driver to be generic, all low-level drivers should recognize
the clkname.X format. But this is the standard syntax for devices
name, so I think this should be correct.
Also clk_for_each() and clk_name() should be added to clock
infrastructure, so they should be implemented in all drivers.
Maybe this should be proposed and discussed with the clock
infrastructure maintainer, but I didn't find him in the MAINTAINER
list. Do you know who is ?
Where do you think the generic user access driver should be placed ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/