linux-kernel - Re: [PATCH] IB: check for memory allocation failure [v2]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49661CD8.9060400@wincor-nixdorf.com>
Date:	Thu, 08 Jan 2009 16:33:44 +0100
From:	Niels de Vos <niels.devos@...cor-nixdorf.com>
To:	Eugene Teo <eugeneteo@...nel.org>
CC:	linux-kernel@...r.kernel.org, rolandd@...co.com,
	sean.hefty@...el.com, hal.rosenstock@...il.com
Subject: Re: [PATCH] IB: check for memory allocation failure [v2]

Eugene Teo wrote:
> On Thu, Jan 8, 2009 at 10:05 PM, Niels de Vos
> <niels.devos@...cor-nixdorf.com> wrote:
>> Hi Eugene,
>>
>> please see below.
> 
> Thanks for reviewing. Here's an updated patch:
> 
> Fix error-path NULL deref in c2_register_device().
> 
> Signed-off-by: Eugene Teo <eugeneteo@...nel.org>

(note: your patch was attached, not inlined...)

There is also an additional kfree() at the end of the patch. It wasn't
included in the first version you sent. Looks correct now imho.

Reviewed-by: Niels de Vos <niels.devos@...cor-nixdorf.com>


> ---
>  drivers/infiniband/hw/amso1100/c2_provider.c |   17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)



Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)