linux-kernel - Re: [Regression] USB wakeup problem on Toshiba Portege R500

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200901081736.12926.rjw@sisk.pl>
Date:	Thu, 8 Jan 2009 17:36:12 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Oliver Neukum <oliver@...kum.org>
Cc:	Alan Stern <stern@...land.harvard.edu>, Greg KH <greg@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	pm list <linux-pm@...ts.linux-foundation.org>,
	Pavel Machek <pavel@...e.cz>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [Regression] USB wakeup problem on Toshiba Portege R500

On Thursday 08 January 2009, Oliver Neukum wrote:
> Am Thursday 08 January 2009 08:35:39 schrieb Rafael J. Wysocki:
> > Hi Alan,
> > 
> > Unfortunately, the following commit:
> > 
> > commit 6fd9086a518d4f14213a32fe6c9ac17fabebbc1e
> > Author: Alan Stern <stern@...land.harvard.edu>
> > Date:   Wed Dec 17 17:20:38 2008 -0500
> > 
> >     USB: automatically enable wakeup for PCI host controllers
> > 
> >     Signed-off-by: Alan Stern <stern@...land.harvard.edu>
> >     Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> > 
> > causes a regression to appear on my Toshiba Portege R500.
> > 
> > The regression is that when suspended to RAM, the box wakes up immediately
> > unless 'disabled' is written into the /sys/devices/.../power/wakeup file of the
> 
> Even without attached devices?

Yes.  This is a platform problem, no doubt, but this patch makes it painfully
visible.

> > EHCI controller.  I know of at least 10 different boxes out there that are
> > going to have similar problems forcing their users to use manual workaround.
> > 
> > Also, it wakes up on a USB mouse activity, which I don't want it to do, so in
> > fact I have to write 'disabled' to the /sys/devices/.../power/wakeup files of
> > all USB controllers.
> 
> We do support remote wakeup from PS2 keyboards. So you might argue we
> should do the same for USB HID devices.

Well, _I_ can live with a few 'echo disabled > /sys/devices/.../power/wakeup'
lines in my init scripts, but I'm afraid we're going to get many problem
reports related to this.  This means people will likely lose time on trying to
debug this problem and someone will have to handle the reports.  Are you
volunteering to do that?

Also, it would have been nice to notify people of such a change of behavior in
advance.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/