linux-kernel - Re: [PATCH 1/5] cpumask: update irq_desc to use cpumask_var

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 08 Jan 2009 11:31:58 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Mike Travis <travis@....com>
CC:	Ingo Molnar <mingo@...hat.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Jack Steiner <steiner@....com>,
	linux-kernel@...r.kernel.org, Chris Wright <chrisw@...s-sol.org>,
	Jeremy Fitzhardinge <jeremy@...source.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>,
	virtualization@...ts.osdl.org, xen-devel@...ts.xensource.com
Subject: Re: [PATCH 1/5] cpumask: update irq_desc to use cpumask_var_t

Mike Travis wrote:
> Yinghai Lu wrote:
> ...
>>> Or am I missing your point?
>> static void init_copy_one_irq_desc(int irq, struct irq_desc *old_desc,
>>                  struct irq_desc *desc, int cpu)
>> {
>>         memcpy(desc, old_desc, sizeof(struct irq_desc));
>>
>>
>> will overwrite new_desc->affinity and pending_mask
>>
>> YH
> 
> Yup, apparently I was missing your point (banging on head once more).
> 
> Thanks for spotting this!
> 
> Ingo - what's the state of tip/cpus4096?  Shall I push this as an
> append patch, or redo the original so bisectability works.
> 
> Also, Yinghai - would you know of a straight forward way to test
> the irq migration?   I have taken cpus offline and back online
> but wasn't sure if any irq's were being moved off of cpu 0 which
> cannot be taken offline.

use echo "mask" > /proc/irq/xxx/smp_affinity to change affinity

and check /proc/interrupts and in /sys/log/messages i will said allocate new irq desc on some other node/cpu.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/