linux-kernel - [PATCH 1/2] CRED: Missing put_cred() in prepare_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090109161341.13371.24540.stgit@warthog.procyon.org.uk>
Date:	Fri, 09 Jan 2009 16:13:41 +0000
From:	David Howells <dhowells@...hat.com>
To:	torvalds@...l.org, jmorris@...ei.org, akpm@...ux-foundation.org
Cc:	dhowells@...hat.com, steved@...hat.com,
	linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org
Subject: [PATCH 1/2] CRED: Missing put_cred() in prepare_kernel_cred()

Missing put_cred() in the error handling path of prepare_kernel_cred().

Signed-off-by: David Howells <dhowells@...hat.com>
Acked-by: Steve Dickson <steved@...hat.com>
---

 kernel/cred.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/cred.c b/kernel/cred.c
index 480a61a..400e608 100644
--- a/kernel/cred.c
+++ b/kernel/cred.c
@@ -530,6 +530,7 @@ struct cred *prepare_kernel_cred(struct task_struct *daemon)
 
 error:
 	put_cred(new);
+	put_cred(old);
 	return NULL;
 }
 EXPORT_SYMBOL(prepare_kernel_cred);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/