linux-kernel - Re: [PATCH 1/1 #2] IWL: fix WARN typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 9 Jan 2009 16:42:16 -0500
From:	"John W. Linville" <linville@...driver.com>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	Tomas Winkler <tomas.winkler@...el.com>
Subject: Re: [PATCH 1/1 #2] IWL: fix WARN typo

People have pointed-out the "kew -> key" part of the patch.
Any thoughts on "new key" vs. "a new key"?

John

On Fri, Jan 09, 2009 at 03:18:00PM -0500, John W. Linville wrote:
> Is the way it is now problematic for non-native English speakers?
> Or native ones for that matter?
> 
> Dropping an article in a "computer-ese" statement has never bothered
> me, so this seems like just a handful of unnecessary string bytes?
> 
> John
> 
> On Mon, Jan 05, 2009 at 05:06:06PM +0100, Jiri Slaby wrote:
> > new kew -> a new key
> > 
> > Signed-off-by: Jiri Slaby <jirislaby@...il.com>
> > Cc: Tomas Winkler <tomas.winkler@...el.com>
> > Cc: John W. Linville <linville@...driver.com>
> > ---
> >  drivers/net/wireless/iwlwifi/iwl-sta.c |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/net/wireless/iwlwifi/iwl-sta.c b/drivers/net/wireless/iwlwifi/iwl-sta.c
> > index 412f66b..ce2ba40 100644
> > --- a/drivers/net/wireless/iwlwifi/iwl-sta.c
> > +++ b/drivers/net/wireless/iwlwifi/iwl-sta.c
> > @@ -638,7 +638,7 @@ static int iwl_set_wep_dynamic_key_info(struct iwl_priv *priv,
> >  	 * in uCode. */
> >  
> >  	WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET,
> > -		"no space for new kew");
> > +		"no space for a new key");
> >  
> >  	priv->stations[sta_id].sta.key.key_flags = key_flags;
> >  	priv->stations[sta_id].sta.sta.modify_mask = STA_MODIFY_KEY_MASK;
> > @@ -686,7 +686,7 @@ static int iwl_set_ccmp_dynamic_key_info(struct iwl_priv *priv,
> >  	 * in uCode. */
> >  
> >  	WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET,
> > -		"no space for new kew");
> > +		"no space for a new key");
> >  
> >  	priv->stations[sta_id].sta.key.key_flags = key_flags;
> >  	priv->stations[sta_id].sta.sta.modify_mask = STA_MODIFY_KEY_MASK;
> > @@ -722,7 +722,7 @@ static int iwl_set_tkip_dynamic_key_info(struct iwl_priv *priv,
> >  	 * in uCode. */
> >  
> >  	WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET,
> > -		"no space for new kew");
> > +		"no space for a new key");
> >  
> >  	/* This copy is acutally not needed: we get the key with each TX */
> >  	memcpy(priv->stations[sta_id].keyinfo.key, keyconf->key, 16);
> > -- 
> > 1.6.0.6
> > 
> > 
> 
> -- 
> John W. Linville		Linux should be at the core
> linville@...driver.com			of your literate lifestyle.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
John W. Linville		Linux should be at the core
linville@...driver.com			of your literate lifestyle.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/