linux-kernel - [PATCH 3/5] Fix dubious bitwise 'and' usage spotted by sparse.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090109234813.11800.84518.stgit@zaytsev.su>
Date:	Sat, 10 Jan 2009 02:48:13 +0300
From:	Alexey Zaytsev <alexey.zaytsev@...il.com>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	Jiri Kosina <jkosina@...e.cz>,
	Trivial Kernel Patches <trivial@...nel.org>
Subject: [PATCH 3/5] Fix dubious bitwise 'and' usage spotted by sparse.

It doesn't change the semantics, but it looks like
the logical 'and' was meant to be used here.
---
 drivers/media/video/gspca/m5602/m5602_s5k4aa.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/gspca/m5602/m5602_s5k4aa.c b/drivers/media/video/gspca/m5602/m5602_s5k4aa.c
index 14b1eac..c3ebcca 100644
--- a/drivers/media/video/gspca/m5602/m5602_s5k4aa.c
+++ b/drivers/media/video/gspca/m5602/m5602_s5k4aa.c
@@ -114,7 +114,7 @@ int s5k4aa_read_sensor(struct sd *sd, const u8 address,
 	if (err < 0)
 		goto out;
 
-	for (i = 0; (i < len) & !err; i++) {
+	for (i = 0; (i < len) && !err; i++) {
 		err = m5602_read_bridge(sd, M5602_XB_I2C_DATA, &(i2c_data[i]));
 
 		PDEBUG(D_CONF, "Reading sensor register "

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/