linux-kernel - Re: [PATCH 4/5] Fix dubious bitwise 'and' usage spotted by sparse.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.1.10.0901100057510.5377@jikos.suse.cz>
Date:	Sat, 10 Jan 2009 00:58:50 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Alexey Zaytsev <alexey.zaytsev@...il.com>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Trivial Kernel Patches <trivial@...nel.org>
Subject: Re: [PATCH 4/5] Fix dubious bitwise 'and' usage spotted by sparse.

On Sat, 10 Jan 2009, Alexey Zaytsev wrote:

> It doesn't change the semantics, but it looks like
> the logical 'and' was meant to be used here.
> 
> Signed-off-by: Alexey Zaytsev <alexey.zaytsev@...il.com>
> ---
>  drivers/net/wireless/ath9k/rc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath9k/rc.c b/drivers/net/wireless/ath9k/rc.c
> index cca2fc5..e8eb20d 100644
> --- a/drivers/net/wireless/ath9k/rc.c
> +++ b/drivers/net/wireless/ath9k/rc.c
> @@ -609,7 +609,7 @@ ath_rc_get_nextvalid_txrate(const struct ath_rate_table *rate_table,
>  
>  static int ath_rc_valid_phyrate(u32 phy, u32 capflag, int ignore_cw)
>  {
> -	if (WLAN_RC_PHY_HT(phy) & !(capflag & WLAN_RC_HT_FLAG))
> +	if (WLAN_RC_PHY_HT(phy) && !(capflag & WLAN_RC_HT_FLAG))
>  		return FALSE;
>  	if (WLAN_RC_PHY_DS(phy) && !(capflag & WLAN_RC_DS_FLAG))
>  		return FALSE;

This one needs a small fixup, as the buggy code got moved around to 
ath_rc_valid_phyrate().

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/