linux-kernel - Re: [PATCH 1/3] Driver for user access to internal clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090108163024.GB26413@suse.de>
Date:	Thu, 8 Jan 2009 08:30:24 -0800
From:	Greg KH <gregkh@...e.de>
To:	Davide Rizzo <elpa.rizzo@...il.com>
Cc:	"Hans J. Koch" <hjk@...utronix.de>, linux-kernel@...r.kernel.org,
	ben-linux@...ff.org
Subject: Re: [PATCH 1/3] Driver for user access to internal clocks

On Thu, Jan 08, 2009 at 05:06:58PM +0100, Davide Rizzo wrote:
> > Davide,
> > please don't put this in the drivers/uio/ directory. This is no UIO driver.
> >
> > Thanks,
> > Hans
> >
> Ok, moved to /drivers/misc
> 
> This driver is for user level programs to interact with system clocks.

Same comments here as for your "timer.c" file:
	- too generic of a name
	- needs proper documentation
	- send any kernel api changes also to linux-api@...r.kernel.org

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/