linux-kernel - Re: todays git: WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090110104114.633cacd8@lxorguk.ukuu.org.uk>
Date:	Sat, 10 Jan 2009 10:41:14 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Christian Borntraeger <borntraeger@...ibm.com>
Cc:	linux-ide@...r.kernel.org, Jeff Garzik <jgarzik@...hat.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: todays git: WARNING: at drivers/ata/libata-sff.c:1017
 ata_sff_hsm_move+0x45e/0x750()

> I did some printk debugging. 
> __atapi_pio_bytes is called with bytes=18. That means with 32bit transfers
> there is a 2 byte trailing transfer, which triggers this WARN_ON.

Ouch.. that means all that someone issued a multiple segment data
transfer with a 2 byte aligned chunk in the middle.

That is a bit of a suprise because we set blk_queue_dma_alignment to 3 so
the block layer should never hand us an sg list in that form. That means
we've either got a block layer bug or someone somewhere is generating
invalid sg lists internally to libata.

Can you dump qc->cdb[] and see what command is getting issued in the
broken form ?

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/