linux-kernel - [PATCH][ATA] Add ide-disk led-trigger to ATA subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1231600107.10065.4.camel@kplaws107lx>
Date:	Sat, 10 Jan 2009 16:08:27 +0100
From:	Carsten Schlote <c.schlote@...zeptpark.de>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH][ATA] Add ide-disk led-trigger to ATA subsystem

- Adds a call to ide-disk LED trigger to libata-sff.c
- Changed Kconfig to allow for ide-disk LED trigger when ATA drivers
  are enabled.

Open Issue:
- There might be more suitable place to call the trigger function.
  Only devices using libata-sff.c trigger LEDs right now.

Signed-off-by: Carsten Schlote <c.schlote@...zeptpark.de>
---
 drivers/ata/libata-sff.c |    3 +++
 drivers/leds/Kconfig     |    2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

Index: .kernel/drivers/leds/Kconfig
===================================================================
--- .kernel.orig/drivers/leds/Kconfig	2009-01-07 22:13:40.000000000
+0100
+++ .kernel/drivers/leds/Kconfig	2009-01-07 22:14:46.000000000 +0100
@@ -185,7 +185,7 @@
 
 config LEDS_TRIGGER_IDE_DISK
 	bool "LED IDE Disk Trigger"
-	depends on LEDS_TRIGGERS && BLK_DEV_IDEDISK
+	depends on LEDS_TRIGGERS && BLK_DEV_IDEDISK || ATA
 	help
 	  This allows LEDs to be controlled by IDE disk activity.
 	  If unsure, say Y.
Index: .kernel/drivers/ata/libata-sff.c
===================================================================
--- .kernel.orig/drivers/ata/libata-sff.c	2009-01-07 22:14:09.000000000
+0100
+++ .kernel/drivers/ata/libata-sff.c	2009-01-07 22:14:46.000000000 +0100
@@ -36,6 +36,7 @@
 #include <linux/pci.h>
 #include <linux/libata.h>
 #include <linux/highmem.h>
+#include <linux/leds.h>
 
 #include "libata.h"
 
@@ -647,6 +648,8 @@
  */
 void ata_sff_exec_command(struct ata_port *ap, const struct
ata_taskfile *tf)
 {
+	ledtrig_ide_activity();
+
 	DPRINTK("ata%u: cmd 0x%X\n", ap->print_id, tf->command);
 
 	iowrite8(tf->command, ap->ioaddr.command_addr);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/