linux-kernel - Re: [PATCH 1/4] irq: change references from NR_IRQS to nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090110224523.GB17917@elte.hu>
Date:	Sat, 10 Jan 2009 23:45:23 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Mike Travis <travis@....com>
Cc:	Ingo Molnar <mingo@...hat.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Yinghai Lu <yinghai@...nel.org>,
	Jack Steiner <steiner@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] irq: change references from NR_IRQS to nr_irqs


* Mike Travis <travis@....com> wrote:

> Impact: preparation, cleanup

s/Impact: preparation, cleanup/Impact: preparation, cleanup, add printk

> @@ -160,9 +162,9 @@ struct irq_desc *irq_to_desc_alloc_cpu(u
>  	unsigned long flags;
>  	int node;
>  
> -	if (irq >= NR_IRQS) {
> -		printk(KERN_WARNING "irq >= NR_IRQS in irq_to_desc_alloc: %d %d\n",
> -				irq, NR_IRQS);
> +	if (irq >= nr_irqs) {
> +		printk(KERN_WARNING "irq >= nr_irqs in irq_to_desc_alloc: %d %d\n",
> +				irq, nr_irqs);
>  		WARN_ON(1);
>  		return NULL;

While at it, could you please also convert this to a WARN() construct 
instead? (in a separate commit)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/