linux-kernel - Re: [PATCH 1/4] irq: change references from NR_IRQS to nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49692AD3.9020401@sgi.com>
Date:	Sat, 10 Jan 2009 15:10:11 -0800
From:	Mike Travis <travis@....com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Ingo Molnar <mingo@...hat.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Yinghai Lu <yinghai@...nel.org>,
	Jack Steiner <steiner@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] irq: change references from NR_IRQS to nr_irqs

Ingo Molnar wrote:
> * Mike Travis <travis@....com> wrote:
> 
>> Impact: preparation, cleanup
> 
> s/Impact: preparation, cleanup/Impact: preparation, cleanup, add printk

Hmm, should I attempt the 'git rebase -i' to change this or just fix up
the patch, and repush (getting new commit ids)?

> 
>> @@ -160,9 +162,9 @@ struct irq_desc *irq_to_desc_alloc_cpu(u
>>  	unsigned long flags;
>>  	int node;
>>  
>> -	if (irq >= NR_IRQS) {
>> -		printk(KERN_WARNING "irq >= NR_IRQS in irq_to_desc_alloc: %d %d\n",
>> -				irq, NR_IRQS);
>> +	if (irq >= nr_irqs) {
>> +		printk(KERN_WARNING "irq >= nr_irqs in irq_to_desc_alloc: %d %d\n",
>> +				irq, nr_irqs);
>>  		WARN_ON(1);
>>  		return NULL;
> 
> While at it, could you please also convert this to a WARN() construct 
> instead? (in a separate commit)
> 
> 	Ingo

Yes, I will.

Thanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/