linux-kernel - Re: libata: make parallel port scan a per-host opt-in feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0901091659180.6528@localhost.localdomain>
Date:	Fri, 9 Jan 2009 17:00:47 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Arjan van de Ven <arjan@...radead.org>
cc:	linux-ide@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	jgarzik@...ox.net
Subject: Re: libata: make parallel port scan a per-host opt-in feature



On Fri, 9 Jan 2009, Linus Torvalds wrote:
> 
> On Fri, 9 Jan 2009, Linus Torvalds wrote:
> > 
> > On Fri, 9 Jan 2009, Arjan van de Ven wrote:
> > >  
> > > +	if (!hpriv->cap & HOST_CAP_SSS)
> > > +		host->flags |= ATA_HOST_PARALLEL_SCAN;
> > > +
> > 
> > I don't think that does what you think it does.
> 
> And furthermore I'm surprised gcc doesn't warn about it. It would seem to 
> be an obvious thing to warn about. I'll see what a sparse warning would 
> look like.

Heh. sparse already warns:

	warning: dubious: !x & y

although I'm not sure that's necessarily the most readable warning ever.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/