linux-kernel - Re: [PATCH] block: Fix register_disk() when name has '/' in it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adahc47ofl5.fsf@cisco.com>
Date:	Fri, 09 Jan 2009 22:11:34 -0800
From:	Roland Dreier <rdreier@...co.com>
To:	Kay Sievers <kay.sievers@...y.org>
Cc:	Jens Axboe <jens.axboe@...cle.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: Fix register_disk() when name has '/' in it

 > > Commit 3ada8b7e ("block: struct device - replace bus_id with dev_name(),
 > > dev_set_name()") deleted the code in register_disk() that changed a '/'
 > > to a '!' in the device name when registering a disk.
 > 
 > Hmm, this is done in the core, for all devices since a while:
 >   http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9f255651fb41c111ee35a2ae632df8ce9bd61def
 > 
 > We should find what is going wrong here, instead of putting that code back.

The commit you point to is for kobject_set_name() ... but dev_set_name()
is still just setting dev->bus_id (at least in Linus's current tree).

If you want I can send a patch putting the conversion into
dev_set_name() for now instead.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/