linux-kernel - Re: [Bug #12422] 2.6.28-git can't resume from str

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090111180714.GB15326@elte.hu>
Date:	Sun, 11 Jan 2009 19:07:14 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jeff Chua <jeff.chua.linux@...il.com>
Cc:	Christian Borntraeger <borntraeger@...ibm.com>,
	Daniel Drake <dsd@...too.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kernel Testers List <kernel-testers@...r.kernel.org>,
	Phil Dibowitz <phil@...m.com>
Subject: Re: [Bug #12422] 2.6.28-git can't resume from str


* Jeff Chua <jeff.chua.linux@...il.com> wrote:

> On Mon, Jan 12, 2009 at 12:39 AM, Ingo Molnar <mingo@...e.hu> wrote:
> > * Christian Borntraeger <borntraeger@...ibm.com> wrote
> >> I guess Jeff, meant the other way around.
> >> Since a0e280e0f33f6c859a235fb69a875ed8f3420388 is a fix for a known S2R
> >> problem , the earlier patch (before) does of course not work.
> > ah, okay.
> > So i suspect that at every bisection point, this should be done:
> >  git cherry-pick a0e280e0f33f6c859a235fb69a875ed8f3420388
> 
> I started with the latest git, and did this ...
> 
> git bisect start
> git bisect bad
> git bisect good a0e280e0f33f6c859a235fb69a875ed8f3420388
> 
> Everything in-between should have
> a0e280e0f33f6c859a235fb69a875ed8f3420388 applied?

not necessarily - if an intermediate tree that is checked happened to have 
been based on some earlier -rc, it might have that bug included. Safest is 
to always cherry-pick that commit. (if it has no dependencies)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/