linux-kernel - Re: [PATCH 1/2] swiotlb: range_needs_mapping should take a physical address.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090111125438G.fujita.tomonori@lab.ntt.co.jp>
Date:	Sun, 11 Jan 2009 12:58:03 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	Ian.Campbell@...rix.com
Cc:	linux-kernel@...r.kernel.org, jeremy@...p.org, mingo@...e.hu,
	fujita.tomonori@....ntt.co.jp, jj@...osbits.net,
	weiyi.huang@...il.com, beckyb@...nel.crashing.org
Subject: Re: [PATCH 1/2] swiotlb: range_needs_mapping should take a
 physical address.

On Fri,  9 Jan 2009 18:32:09 +0000
Ian Campbell <Ian.Campbell@...rix.com> wrote:

> The swiotlb_arch_range_needs_mapping() hook should take a physical
> address rather than a virtual address in order to support highmem pages.
> 
> Signed-off-by: Ian Campbell <ian.campbell@...rix.com>
> ---
>  arch/x86/kernel/pci-swiotlb_64.c |    2 +-
>  include/linux/swiotlb.h          |    2 +-
>  lib/swiotlb.c                    |   10 +++++-----
>  3 files changed, 7 insertions(+), 7 deletions(-)

Yeah, using a cpu address here doesn't make sense. I wondered what you
were trying with a cpu address when reading your original patch.

Might be more clean to unify address_needs_mapping and
range_needs_mapping. I guess that I need to see what Xen wants to do
with this though.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/