[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20090112154357.4f4d4f48@mjolnir.drzeus.cx>
Date: Mon, 12 Jan 2009 15:43:57 +0100
From: Pierre Ossman <drzeus-mmc@...eus.cx>
To: Ben Dooks <ben-linux@...ff.org>
Cc: Yauhen Kharuzhy <jekhor@...il.com>, linux-kernel@...r.kernel.org,
Yauhen Kharuzhy <jekhor@...il.com>
Subject: Re: [PATCH] s3cmci: Fix hangup in do_pio_write()
On Thu, 1 Jan 2009 13:09:04 +0200
Yauhen Kharuzhy <jekhor@...il.com> wrote:
> This commit fixes the regression what was added by commit
> 088a78af978d0c8e339071a9b2bca1f4cb368f30 "s3cmci: Support transfers
> which are not multiple of 32 bits."
>
> fifo_free() now returns amount of available space in FIFO buffer in
> bytes. But do_pio_write() writes to FIFO 32-bit words. Condition for
> return from cycle is (fifo_free() == 0), but when fifo has 1..3 bytes of
> free space then this condition will never be true and system hangs.
>
> This patch changes condition in the while() to (fifo_free() > 3).
>
> Signed-off-by: Yauhen Kharuzhy <jekhor@...il.com>
Any objections here Ben? An Acked-by would be nice.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists