linux-kernel - Re: [PATCH 22/24] i386: add TRACE_IRQS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090112183904.GC12249@elte.hu>
Date:	Mon, 12 Jan 2009 19:39:04 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	heukelum@...tmail.fm, linux-kernel@...r.kernel.org, ak@...e.de,
	Dhaval Giani <dhaval@...ux.vnet.ibm.com>
Subject: Re: [PATCH 22/24] i386: add TRACE_IRQS_OFF for the nmi


* Peter Zijlstra <peterz@...radead.org> wrote:

> On Tue, 2008-09-09 at 21:56 +0200, heukelum@...tmail.fm wrote:
> > From: Alexander van Heukelum <heukelum@...tmail.fm>
> > 
> > At this point interrupts are off, so let's inform the tracing
> > code of that fact before calling into C.
> 
> Sorry but this is an obvious dud, lockdep (and thus the irq state
> tracer) aren't nmi safe.
> 
> Ingo, please revert, as people are already seeing lockdep warnings due
> to this.

done - reverted it in tip/x86/urgent, see the commit below. Is that all 
that we need, wasnt there a 64-bit side done too?

	Ingo

--------------->
>From e8cea892dff8e3ebed42954c46730309b617196f Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@...e.hu>
Date: Mon, 12 Jan 2009 19:36:59 +0100
Subject: [PATCH] Revert "i386: add TRACE_IRQS_OFF for the nmi"

This reverts commit e0c7317557c8fc8eacf611e30c2a80f4e24e47a3.

This patch was wrong, as lockdep (and thus the irq state tracer)
aren't nmi safe. People are already seeing lockdep warnings due
to this.

Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/x86/kernel/entry_32.S |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
index d6f0490..4646902 100644
--- a/arch/x86/kernel/entry_32.S
+++ b/arch/x86/kernel/entry_32.S
@@ -1203,7 +1203,6 @@ nmi_stack_correct:
 	pushl %eax
 	CFI_ADJUST_CFA_OFFSET 4
 	SAVE_ALL
-	TRACE_IRQS_OFF
 	xorl %edx,%edx		# zero error code
 	movl %esp,%eax		# pt_regs pointer
 	call do_nmi
@@ -1244,7 +1243,6 @@ nmi_espfix_stack:
 	pushl %eax
 	CFI_ADJUST_CFA_OFFSET 4
 	SAVE_ALL
-	TRACE_IRQS_OFF
 	FIXUP_ESPFIX_STACK		# %eax == %esp
 	xorl %edx,%edx			# zero error code
 	call do_nmi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/