linux-kernel - Re: [PATCH 2/2] [RESEND] tracing: Add a new workqueue tracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0901121459310.28952@gandalf.stny.rr.com>
Date:	Mon, 12 Jan 2009 15:00:01 -0500 (EST)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH 2/2] [RESEND] tracing: Add a new workqueue tracer


On Mon, 12 Jan 2009, Frederic Weisbecker wrote:
> > WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(), 
> > num_possible_cpus(), for_each_possible_cpu(), etc
> > #953: FILE: kernel/trace/trace_workqueue.c:153:
> > +	for (i = 0; i < NR_CPUS; i++) {
> > 
> > We should probably change them to for_each_possible_cpu, or online cpu.
> > 
> > -- Steve
> 
> 
> I found it very convenient because I didn't have to allocate
> my cpu list array dynamically with it :-)
> 
> I'm preparing a v2...
>  

Thanks!

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/