linux-kernel - Re: linux-next: Tree for January 12 (cifs vs. staging)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090112202136.GA8854@suse.de>
Date:	Mon, 12 Jan 2009 12:21:36 -0800
From:	Greg KH <gregkh@...e.de>
To:	Steve French <smfrench@...il.com>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	sfrench@...ba.org
Subject: Re: linux-next: Tree for January 12 (cifs vs. staging)

On Mon, Jan 12, 2009 at 02:13:29PM -0600, Steve French wrote:
> On Mon, Jan 12, 2009 at 1:32 PM, Greg KH <gregkh@...e.de> wrote:
> > On Mon, Jan 12, 2009 at 01:23:07PM -0600, Steve French wrote:
> >> Is there some magic compile option alternative (other than renaming
> >> the function, which may be ok, since others probably don't depend on
> >> it)?  MD5Init is used outside fs/cifs/md5.c so can't be static
> >
> > No, you should rename it to cifs_md5init to show that it is only for the
> > cifs module to use.  Try not to polute the global namespace with generic
> > function names.
> 
> Looks like cifs has the following related functions which I can rename
> if that makes it easier:
> 001a2e9 R_386_PC32        MD5Final
> 0001a302 R_386_PC32        MD5Update
> 0001a38c R_386_PC32        MD5Init
> 0001a39f R_386_PC32        MD5Update

That would make life easier for you as well :)

> Any others that I missed ...

Not that I see at the moment, but you might want to look at all of your
global symbol names to make sure they start with "cifs_".

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/