linux-kernel - Re: [git pull] x86 fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1231794230.5405.1.camel@brick>
Date:	Mon, 12 Jan 2009 13:03:49 -0800
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>,
	Torsten Kaiser <just.for.lkml@...glemail.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [git pull] x86 fixes

On Mon, 2009-01-12 at 21:52 +0100, Ingo Molnar wrote:
> * Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> +static inline int is_new_memtype_allowed(unsigned long flags,
> +                                               unsigned long new_flags)
> +{
> +       /*
> +        * Certain new memtypes are not allowed with certain
> +        * requested memtype:
> +        * - request is uncached, return cannot be write-back
> +        * - request is write-combine, return cannot be write-back
> +        */
> +       if ((flags == _PAGE_CACHE_UC_MINUS &&
> +            new_flags == _PAGE_CACHE_WB) ||
> +           (flags == _PAGE_CACHE_WC &&
> +            new_flags == _PAGE_CACHE_WB)) {
> +               return 0;
> +       }

	if ((flags == _PAGE_CACHE_UC_MINUS || flags == _PAGE_CACHE_WC) &&
	    (new_flags == _PAGE_CACHE_WB))

might be a bit neater perhaps.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/