linux-kernel - Re: [PATCH for 2.6.28 stable] m68knommu: fix m68knommu defconfig can't build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48E9AE16.2000002@snapgear.com>
Date:	Mon, 06 Oct 2008 16:20:06 +1000
From:	Greg Ungerer <gerg@...pgear.com>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Roman Zippel <zippel@...ux-m68k.org>,
	Greg Ungerer <gerg@...inux.org>,
	linux-m68k@...ts.linux-m68k.org, stable@...nel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH for 2.6.28 stable] m68knommu: fix m68knommu defconfig
 can't build

Hi Kosako,

KOSAKI Motohiro wrote:
> I guess nobody don't test m68knommu at all last three month.
> Do we still need to maintain this architecture?

Yes, we do.

Regards
Greg



> ==
> Currently, m68knommu defconfig can't build. it cause following error.
> 
> net/built-in.o: In function `skb_dma_map':
> : undefined reference to `dma_mapping_error'
> net/built-in.o: In function `skb_dma_unmap':
> : undefined reference to `dma_unmap_single'
> net/built-in.o: In function `skb_dma_unmap':
> : undefined reference to `dma_unmap_page'
> net/built-in.o: In function `skb_dma_map':
> : undefined reference to `dma_map_single'
> net/built-in.o: In function `skb_dma_map':
> : undefined reference to `dma_map_page'
> net/built-in.o: In function `skb_dma_map':
> : undefined reference to `dma_unmap_page'
> net/built-in.o: In function `skb_dma_map':
> : undefined reference to `dma_unmap_single'
> 
> because
>  - CONFIG_DMA depend on !NO_DMA
>  - m68knommu always doesn't turn on NO_DMA
>  - if CONFIG_PCI=n, m68knommu/include/asm/dma-magging.h include
>     asm-generic/dma-mapping-broken.h
>  - dma-mapping-broken.h generate link time error.
>  - m68knommu defconfig doesn't have CONFIG_PCI
>  - On the other hand, net/core/skb_dma_map.c assume CONFIG_DMA=y mean
>    dma related function is callable
> 
> So, we want to turn on CONFIG_DMA if CONFIG_PCI=y only.
> 
> 
> CC: David S. Miller <davem@...emloft.net>
> CC: Geert Uytterhoeven <geert@...ux-m68k.org>
> CC: Roman Zippel <zippel@...ux-m68k.org>
> CC: Greg Ungerer <gerg@...inux.org>
> CC: linux-m68k@...ts.linux-m68k.org
> ---
>  arch/m68knommu/Kconfig |    3 +++
>  1 file changed, 3 insertions(+)
> 
> Index: b/arch/m68knommu/Kconfig
> ===================================================================
> --- a/arch/m68knommu/Kconfig	2008-12-25 08:26:37.000000000 +0900
> +++ b/arch/m68knommu/Kconfig	2008-12-28 21:09:58.000000000 +0900
> @@ -73,6 +73,9 @@ config GENERIC_CLOCKEVENTS
>  config NO_IOPORT
>  	def_bool y
>  
> +config NO_DMA
> +	def_bool !PCI
> +
>  source "init/Kconfig"
>  
>  source "kernel/Kconfig.freezer"
> 
> 
> 

-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@...pgear.com
SnapGear, a McAfee Company                  PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/