linux-kernel - Re: [PATCH 2/2] resume: wait for device probing to finish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200901130136.59293.rjw@sisk.pl>
Date:	Tue, 13 Jan 2009 01:36:58 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	linux-kernel@...r.kernel.org, greg@...ah.com,
	Len Brown <lenb@...nel.org>
Subject: Re: [PATCH 2/2] resume: wait for device probing to finish

On Saturday 10 January 2009, Arjan van de Ven wrote:
> (this patch needs testing on a few different machines; compile tested only)
> 
> 
> From 10b3e25671c817933e232498a56640fd48964345 Mon Sep 17 00:00:00 2001
> From: Arjan van de Ven <arjan@...ux.intel.com>
> Date: Fri, 9 Jan 2009 21:11:23 -0800
> Subject: [PATCH] resume: wait for device probing to finish
> 
> the resume code does not currently wait for device probing to finish.
> Even without async function calls this is dicey and not correct,
> but with async function calls during the boot sequence this is going
> to get hit more...
> 
> This patch adds the synchronization using the newly introduced helper.
> 
> Signed-off-by: Arjan van de Ven <arjan@...ux.intel.com>

Sorry for the delay, but I only could do the testing today.

It appears that 2.6.29-rc1 with the two patches in this series applied resumes
from hibernation correctly.

Please push the second one to Len with my ack.

Thanks,
Rafael


> ---
>  kernel/power/disk.c |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/power/disk.c b/kernel/power/disk.c
> index 45e8541..d2d24b7 100644
> --- a/kernel/power/disk.c
> +++ b/kernel/power/disk.c
> @@ -585,6 +585,12 @@ static int software_resume(void)
>  	unsigned int flags;
>  
>  	/*
> +	 * If the user said "noresume".. bail out early.
> +	 */
> +	if (noresume)
> +		return 0;
> +
> +	/*
>  	 * name_to_dev_t() below takes a sysfs buffer mutex when sysfs
>  	 * is configured into the kernel. Since the regular hibernate
>  	 * trigger path is via sysfs which takes a buffer mutex before
> @@ -600,6 +606,11 @@ static int software_resume(void)
>  			mutex_unlock(&pm_mutex);
>  			return -ENOENT;
>  		}
> +		/*
> +		 * Some device discovery might still be in progress; we need
> +		 * to wait for this to finish.
> +		 */
> +		wait_for_device_probe();
>  		swsusp_resume_device = name_to_dev_t(resume_file);
>  		pr_debug("PM: Resume from partition %s\n", resume_file);
>  	} else {
> -- 
> 1.6.0.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/