linux-kernel - Re: [PATCH] NET: fix wrong English expression in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Jan 2009 14:16:02 +0800
From:	Daolong Wang <ahlongxp@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	bhutchings@...arflare.com, lizf@...fujitsu.com,
	qhfeng.kernel@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] NET: fix wrong English expression in comments

The patch will make sense for some people. I was puzzled about the
double-negative for quite a while.

On Tue, Jan 13, 2009 at 1:53 PM, David Miller <davem@...emloft.net> wrote:
> From: Ben Hutchings <bhutchings@...arflare.com>
> Date: Mon, 12 Jan 2009 01:39:18 +0000
>
>> On Mon, 2009-01-12 at 09:05 +0800, Li Zefan wrote:
>> > > @@ -103,7 +103,7 @@ struct inet_bind_bucket;
>> > >  struct inet_timewait_sock {
>> > >   /*
>> > >    * Now struct sock also uses sock_common, so please just
>> > > -  * don't add nothing before this first member (__tw_common) --acme
>> > > +  * don't add anything before this first member (__tw_common) --acme
>> >
>> > They are the same meaning...
>>
>> A double-negative can be an informal way of reinforcing a negative, but
>> can sometimes mean the positive.  So this change would remove a minor
>> ambiguity.  However I think it should be clear that it is not compulsory
>> to add new members to the structure. ;-)
>
> After all of this discussion, I think I'm going to keep this comment
> as-is. :-)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/