linux-kernel - Re: [PATCH] capability.h: extern's make no sense in userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 Jan 2009 00:01:26 -0800
From:	"Andrew G. Morgan" <morgan@...nel.org>
To:	Jaswinder Singh Rajput <jaswinder@...radead.org>
CC:	Ingo Molnar <mingo@...e.hu>, sam@...nborg.org,
	harvey.harrison@...il.com, gorcunov@...il.com, astor@...rdian.no,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] capability.h: extern's make no sense in userspace

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Acked-by: Andrew G. Morgan <morgan@...nel.org>

Cheers

Andrew

Jaswinder Singh Rajput wrote:
> Impact: fix 2 make headers_check warnings:
> 
>  usr/include/linux/capability.h:72: leaks CONFIG_SECURITY to userspace where it is not valid
>  usr/include/linux/capability.h:73: extern's make no sense in userspace
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> ---
>  include/linux/capability.h |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/capability.h b/include/linux/capability.h
> index 02bdb76..1b98725 100644
> --- a/include/linux/capability.h
> +++ b/include/linux/capability.h
> @@ -69,10 +69,6 @@ typedef struct __user_cap_data_struct {
>  #define VFS_CAP_U32             VFS_CAP_U32_2
>  #define VFS_CAP_REVISION	VFS_CAP_REVISION_2
>  
> -#ifdef CONFIG_SECURITY_FILE_CAPABILITIES
> -extern int file_caps_enabled;
> -#endif
> -
>  struct vfs_cap_data {
>  	__le32 magic_etc;            /* Little endian */
>  	struct {
> @@ -96,6 +92,10 @@ struct vfs_cap_data {
>  #define _KERNEL_CAPABILITY_VERSION _LINUX_CAPABILITY_VERSION_3
>  #define _KERNEL_CAPABILITY_U32S    _LINUX_CAPABILITY_U32S_3
>  
> +#ifdef CONFIG_SECURITY_FILE_CAPABILITIES
> +extern int file_caps_enabled;
> +#endif
> +
>  typedef struct kernel_cap_struct {
>  	__u32 cap[_KERNEL_CAPABILITY_U32S];
>  } kernel_cap_t;
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJbEpT+bHCR3gb8jsRAnafAJ9CohxNIoKkQN5k+VEzFGGtIjdOsACcDQ3e
B/8spQ/5sSkyGQIN1kK0N9g=
=nkwT
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/