linux-kernel - Re: [PATCH] NET: fix wrong English expression in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090113090402.33d36725@lxorguk.ukuu.org.uk>
Date:	Tue, 13 Jan 2009 09:04:02 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	David Newall <davidn@...idnewall.com>
Cc:	Daolong Wang <ahlongxp@...il.com>,
	David Miller <davem@...emloft.net>, bhutchings@...arflare.com,
	lizf@...fujitsu.com, qhfeng.kernel@...il.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] NET: fix wrong English expression in comments

> "Don't add nothing," is not a colloquialism; it's just bad grammar.  The

It's a matter of dialect. For historical reasons English emerged from a
mix of languages and cultures (even within the UK). In some of the
originating languages and areas a double negative is emphatic in others
it negates the negation. Thus it is a bad idea when using globally - as
nobody is quite sure what you mean.

> As with spelling errors, corrections of this sort of thing are trivial
> and a waste of time.  I'm opposed to patches like that; they add no
> value and could be said to remove "character"; if that's important.

You may be so opposed, but they can be very problematic to non-English
speakers trying to use a dictionary or to understand if they are seeing a
typo or an unknown word: thus we do fix them. This is why we have the
trivial patch maintainer for such small fixes.

TRIVIAL PATCHES
P:	Jiri Kosina
M:	trivial@...nel.org
L:	linux-kernel@...r.kernel.org
T:	git kernel.org:/pub/scm/linux/kernel/git/jikos/trivial.git
S:	Maintained
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/