linux-kernel - Re: [Regression] USB wakeup problem on Toshiba Portege R500

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200901131213.26836.rjw@sisk.pl>
Date:	Tue, 13 Jan 2009 12:13:25 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Frans Pop <elendil@...net.nl>, oliver@...kum.org, gregkh@...e.de,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-pm@...ts.linux-foundation.org, pavel@...e.cz,
	torvalds@...ux-foundation.org,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	Len Brown <lenb@...nel.org>
Subject: Re: [Regression] USB wakeup problem on Toshiba Portege R500

On Tuesday 13 January 2009, Alan Stern wrote:
> On Mon, 12 Jan 2009, Rafael J. Wysocki wrote:
> 
> > On Monday 12 January 2009, Alan Stern wrote:
> > > On Fri, 9 Jan 2009, Rafael J. Wysocki wrote:
> > > 
> > > > > My proposal:
> > > > > 
> > > > > 	Devices and events that are clearly associated with system
> > > > > 	wakeup should be enabled by default.  For example: Power
> > > > > 	button and laptop lid.
> > > > 
> > > > Agreed.
> > > > 
> > > > > 	All other devices capable of waking up the system should be
> > > > > 	disabled by default.  This presumably includes every PCI
> > > > > 	device.  If users want keyboard or mouse events to cause
> > > > > 	a system resume then they will have to configure their
> > > > > 	desktop management program to enable it.
> > > > 
> > > > I generally agree, with one exception.  There are network adapters which
> > > > can be enabled to wake up by the BIOS and their drivers set them up for WoL
> > > > currently on this basis.  These should remain enabled IMO.
> > > 
> > > How do we know which adapters these are?  IMO the PCI core should
> > > disable wakeup by default for all devices when they are detected.
> > 
> > This is what we do.
> > 
> > > Is it sufficient to have the adapter drivers enable wakeup during
> > > their probe routines?
> > 
> > Yes, it is.
> 
> Therefore all we need is a patch to change the USB host controller
> drivers.  They should call device_set_wakeup_capable() instead of
> device_init_wakeup().
> 
> I just got back from vacation so things will be busy for a few days, 
> but I'll send out such a patch soon.

Great, thanks a lot!

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/