linux-kernel - Re: [PATCH] serial: pnx8xxx_uart: Fix break signal handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090113121135.5565b302@lxorguk.ukuu.org.uk>
Date:	Tue, 13 Jan 2009 12:11:35 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Jonker M.D.S.X." <nlv14114@...nl-htc01.nxp.com>
Cc:	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	m.d.s.x.jonker@...il.com
Subject: Re: [PATCH] serial: pnx8xxx_uart: Fix break signal handling

On Tue, 13 Jan 2009 12:09:13 +0100
"Jonker M.D.S.X." <nlv14114@...nl-htc01.nxp.com> wrote:

> From: Mischa Jonker <mischa.jonker@....com>
> 
> When a break signal is detected, the next character should be ignored.
> This was not implemented correctly for the pnx8xxx_uart driver.
> 
> Signed-off-by: Mischa Jonker <mischa.jonker@....com>
> ---
> 
> diff --git a/drivers/serial/pnx8xxx_uart.c b/drivers/serial/pnx8xxx_uart.c
> index 22e30d2..1bb8f1b 100644
> --- a/drivers/serial/pnx8xxx_uart.c
> +++ b/drivers/serial/pnx8xxx_uart.c
> @@ -187,7 +187,7 @@ static void pnx8xxx_rx_chars(struct pnx8xxx_port *sport)
>  	status = FIFO_TO_SM(serial_in(sport, PNX8XXX_FIFO)) |
>  		 ISTAT_TO_SM(serial_in(sport, PNX8XXX_ISTAT));
>  	while (status & FIFO_TO_SM(PNX8XXX_UART_FIFO_RXFIFO)) {
> -		ch = serial_in(sport, PNX8XXX_FIFO);
> +		ch = serial_in(sport, PNX8XXX_FIFO) & 0xff;

This appears to be unrelated.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/