linux-kernel - Re: [PATCH] serial: pnx8xxx_uart: Fix break signal handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090113134812.0ff43e4e@lxorguk.ukuu.org.uk>
Date:	Tue, 13 Jan 2009 13:48:12 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Mischa Jonker" <m.d.s.x.jonker@...il.com>
Cc:	"Jonker M.D.S.X." <nlv14114@...nl-htc01.nxp.com>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: pnx8xxx_uart: Fix break signal handling

> > This appears to be unrelated.
> >
> 
> Correct, you can look to it as two separate bugs:
> a) the next character is not ignored while it should;
> b) the status bits 31-8 are copied to the 'ch' variable while they shouldn't.
> 
> Both bugs prevent correct break signal handling (and therefore correct
> behaviour of the magic SysRq key). Bug b didn't cause too much trouble
> earlier because in most situations the status bits are all zero; for
> this case they unfortunately aren't.

Ok that makes sense - no need to split them.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/