linux-kernel - Re: [PATCH -tip] x86: headers - include linux/types.h instead of asm/types.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090113144505.GA4488@elte.hu>
Date:	Tue, 13 Jan 2009 15:45:05 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	Harvey Harrison <harvey.harrison@...il.com>,
	Sam Ravnborg <sam@...nborg.org>,
	Jaswinder Singh Rajput <jaswinderrajput@...il.com>
Subject: Re: [PATCH -tip] x86: headers - include linux/types.h instead of
	asm/types.h


* Cyrill Gorcunov <gorcunov@...il.com> wrote:

> [Ingo Molnar - Tue, Jan 13, 2009 at 01:59:28PM +0100]
> | 
> | * Cyrill Gorcunov <gorcunov@...il.com> wrote:
> | 
> | > [Cyrill Gorcunov - Tue, Jan 13, 2009 at 03:09:05PM +0300]
> | > | Impact: cleanup
> | > | 
> | > | 'make headers_check' warns that linux/types.h is
> | > | preferred over asm/types.h. So be it.
> | > | 
> | > | Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
> | > | CC: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> | > | CC: Sam Ravnborg <sam@...nborg.org>
> | > | CC: Harvey Harrison <harvey.harrison@...il.com>
> | > | ---
> | > | 
> | > |  arch/x86/include/asm/e820.h       |    2 ++
> | > |  arch/x86/include/asm/kvm.h        |    2 +-
> | > |  arch/x86/include/asm/mce.h        |    2 +-
> | > |  arch/x86/include/asm/mtrr.h       |    1 +
> | > |  arch/x86/include/asm/ptrace-abi.h |    2 +-
> | > |  arch/x86/include/asm/sigcontext.h |    2 +-
> | > |  arch/x86/include/asm/swab.h       |    2 +-
> | > |  7 files changed, 8 insertions(+), 5 deletions(-)
> | > |
> | > ...
> | > 
> | > well... on the other hand I'm not sure if it's really
> | > a good idea to include linux/types.h where we need only
> | > __u[8,16] and so on definitions.
> | 
> | Well, linux/types.h is supposed to be a 'lightweight', 'core data types 
> | only' kind of header file, so including it is not wrong per se.
> | 
> | Sam, is there some other preferred way perhaps to resolve these?
> | 
> | 	Ingo
> | 
> 
> Until such a file not passed to some *.S. For example for e820.h we have 
> it included to arch/x86/boot/header.S but fortunately we're bound by 
> __ASSEMBLY__. So there linux/types.h shouldn't hurt. Will check others 
> and report then.

Any reason to not protect types.h with #ifndef __ASSEMBLY__ ?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/