linux-kernel - Re: [PATCH 1/2] async: Handle kthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090113165115.GR12431@fluff.org.uk>
Date:	Tue, 13 Jan 2009 16:51:15 +0000
From:	Ben Dooks <ben-linux@...ff.org>
To:	Cornelia Huck <cornelia.huck@...ibm.com>
Cc:	Arjan van de Ven <arjan@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] async: Handle kthread_run() return codes.

On Tue, Jan 13, 2009 at 05:43:04PM +0100, Cornelia Huck wrote:
> If we fail to create the manager thread, fall back to non-fastboot.
> If we fail to create an async thread, try again when the manager
> thread runs again.
> 
> Signed-off-by: Cornelia Huck <cornelia.huck@...ibm.com>
> 
> ---
>  kernel/async.c |   11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> --- linux-2.6.orig/kernel/async.c
> +++ linux-2.6/kernel/async.c
> @@ -315,11 +315,14 @@ static int async_manager_thread(void *un
>  		ec = atomic_read(&entry_count);
>  
>  		while (tc < ec && tc < MAX_THREADS) {

why not add the following to stop the wrapping of kthread_run:

+   	    		struct task_struct *kt;
			kt = kthread_run(async_thread, NULL, "async/%i", tc);
			if (IS_ERR(kt))
				goto schedule;

also, I belive the goto isn't necessary, just break out of the while

			if (IS_ERR(kt))
				break;
				
> -			kthread_run(async_thread, NULL, "async/%i", tc);
> +			if (IS_ERR(kthread_run(async_thread, NULL, "async/%i",
> +					       tc)))
> +				/* Try again later. */
> +				goto schedule;
>  			atomic_inc(&thread_count);
>  			tc++;
>  		}
> -
> +schedule:
>  		schedule();
>  	}
>  	remove_wait_queue(&async_new, &wq);
> @@ -330,7 +333,9 @@ static int async_manager_thread(void *un
>  static int __init async_init(void)
>  {
>  	if (async_enabled)
> -		kthread_run(async_manager_thread, NULL, "async/mgr");
> +		if (IS_ERR(kthread_run(async_manager_thread, NULL,
> +				       "async/mgr")))
> +			async_enabled = 0;
>  	return 0;
>  }
>  
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Ben (ben@...ff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/