linux-kernel - Re: [PATCH -v9][RFC] mutex: implement adaptive spinning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090113181222.GA24910@elte.hu>
Date:	Tue, 13 Jan 2009 19:12:22 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Gregory Haskins <ghaskins@...ell.com>,
	Matthew Wilcox <matthew@....cx>,
	Andi Kleen <andi@...stfloor.org>,
	Chris Mason <chris.mason@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	linux-btrfs <linux-btrfs@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Nick Piggin <npiggin@...e.de>,
	Peter Morreale <pmorreale@...ell.com>,
	Sven Dietrich <SDietrich@...ell.com>,
	Dmitry Adamushko <dmitry.adamushko@...il.com>
Subject: Re: [PATCH -v9][RFC] mutex: implement adaptive spinning


* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> 
> 
> On Tue, 13 Jan 2009, Peter Zijlstra wrote:
> > 
> > Ok, tested only 1, but that was the one I remember lockups from -- and
> > that seems to be good with the cmpxchg.
> > 
> > Do you fancy me sending v10 or will you make that change locally?
> 
> I'd like to get this in, but I'm not going to apply it in any case 
> without way more testing.
> 
> It missed the merge window, but I'm potentially willing to let it slip 
> in - but only if there are a fair number of people willing to do numbers 
> and some harsh testing. Preferably people who did see problems earlier, 
> ie at a minimum Chris and Ingo under the loads they used before and saw 
> issues with.

I am tracking Peter's code in tip/core/locking:

 c10b491: mutex: implement adaptive spinning, v8
 c356a7c: mutex: implement adaptive spinning, v7
 b89e5d8: mutex: implement adaptive spinning, v6
 237ac94: mutex: implement adaptive spinning

And v8 is rock solid in all my testing - and i'll give v10 a similar 
workout as well.

Would you prefer a single commit or is this kind of delta development 
history useful, with all the variants (at least the later, more promising 
ones) included?

The commits are in a tight group with no merges inbetween.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/