linux-kernel - Re: [PATCH] ring_buffer: NUMA aware page allocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090113012937.GB15492@elte.hu>
Date:	Tue, 13 Jan 2009 02:29:37 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Eric Dumazet <dada1@...mosbay.com>
Cc:	Robert Richter <robert.richter@....com>,
	Steven Rostedt <rostedt@...hat.com>,
	linux kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ring_buffer: NUMA aware page allocations


* Eric Dumazet <dada1@...mosbay.com> wrote:

> Hi Robert & Steven
> 
> While browsing oprofile code in current tree, I discovered 
> drivers/oprofile/cpu_buffer.c was using new ring_buffer code.
> 
> Apparently we lost in the conversion NUMA allocations, unless
> I am mistaken, since rb_allocate_pages() uses plain
> __get_free_page(GFP_KERNEL) calls to allocate pages.
> 
> All "buffer_page" structs are allocated with kzalloc_node(),
> but not the pages themselves.
> 
> Thank you
> 
> [PATCH] ring_buffer: NUMA aware page allocations
> 
> rb_allocate_pages() & ring_buffer_resize() should use alloc_pages_node()
> instead of __get_free_page() to allocate pages.

nice improvement!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/