linux-kernel - Re: [PATCH] fix early_serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 Jan 2009 16:55:26 -0500
From:	Kyle McMartin <kyle@...radead.org>
To:	Helge Deller <deller@....de>
Cc:	David Daney <ddaney@...iumnetworks.com>,
	Tomaso Paoletti <tpaoletti@...iumnetworks.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Kyle McMartin <kyle@...artin.ca>,
	Linux Kernel Development <linux-kernel@...r.kernel.org>,
	linux-serial@...r.kernel.org, "Rafael J. Wysocky" <rjw@...k.pl>,
	linux-parisc@...r.kernel.org
Subject: Re: [PATCH] fix early_serial_setup() regression

On Tue, Jan 13, 2009 at 10:51:07PM +0100, Helge Deller wrote:
> commit b430428a188e8a434325e251d0704af4b88b4711,
> 	"8250: Don't clobber spinlocks."
> introduced a regression on the parisc architecture, which
> broke the handover to the serial port at boottime.
> 
> early_serial_setup() was changed to only copy a subset of the
> uart_port fields, and sadly the "type" and "line" fields
> were forgotten and thus the serial port was not initialized
> and could not be used for a handover.
> This patch fixes this by copying the missing fields.
> 
> As this change to early_serial_setup() doesn't need an 
> initialized spinlock in the uart_port struct any longer, we
> can drop the spinlock initialization in the superio driver.
> 
> CC: David Daney <ddaney@...iumnetworks.com>
> CC: Tomaso Paoletti <tpaoletti@...iumnetworks.com>
> CC: Andrew Morton <akpm@...ux-foundation.org>
> CC: Alan Cox <alan@...rguk.ukuu.org.uk>
> CC: Linus Torvalds <torvalds@...ux-foundation.org>
> CC: Kyle McMartin <kyle@...artin.ca>
> CC: linux-parisc@...r.kernel.org
> 
> Signed-off-by: Helge Deller <deller@....de>
> 

Acked-by: Kyle McMartin <kyle@...artin.ca>

Linus, please apply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/