linux-kernel - Re: [PATCH 4/5] ftrace: show ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090113231617.GD3210@redhat.com>
Date:	Tue, 13 Jan 2009 18:16:17 -0500
From:	Jason Baron <jbaron@...hat.com>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/5] ftrace: show ftrace_bprintk()'s formats

On Wed, Dec 31, 2008 at 10:56:23AM +0800, Lai Jiangshan wrote:
> 
> Impact: let user knows the format
> 
> Create a file on <debugfs-dir>/tracing/ to show ftrace_bprintk()'s formats.
> 
> This formats will help for these condition:
> 1) User get binary data from core file.(formats are backup before coredump)
> 2) User splice ring_buffer to a file.
> User can use formats for parsing the binary data in userspace.
> 

When I 'cat' trace_bprintk_formats on my system the file is empty. This
seems to be b/c 'ftrace_bprintk' is not being used in this patchset. It
can't be used in patch #5 during marker register b/c the format wouldn't
be known at runtime. Thus, as it currently stands this patch, patch 4/5,
isn't adding much?

A thought on how this might be resolved would be to have the core marker
code pass us its address so this could be recorded in the trace buffer.
Then, also add some debug file that displays the markers and maps marker
addresses with format strings.

thanks,

-Jason

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/