linux-kernel - Re: [ltt-dev] LTTng 0.74 for Linux 2.6.28 (ext4 tracepoints) (fixed in LTTng 0.78)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090114085427.442F.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Date:	Wed, 14 Jan 2009 08:57:21 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Mathieu Desnoyers <compudj@...stal.dyndns.org>
Cc:	kosaki.motohiro@...fujitsu.com,
	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	ltt-dev@...ts.casi.polymtl.ca, Theodore Tso <tytso@....edu>,
	linux-kernel@...r.kernel.org
Subject: Re: [ltt-dev] LTTng 0.74 for Linux 2.6.28 (ext4 tracepoints) (fixed in LTTng 0.78)

> * KOSAKI Motohiro (kosaki.motohiro@...fujitsu.com) wrote:
> > Hi Mathieu
> > 
> > 2009/1/11 Mathieu Desnoyers <compudj@...stal.dyndns.org>:
> > > Hi,
> > >
> > > LTTng 0.74 fixes the probe Makefile to build the net-trace probe module.
> > > It also adds jbd2 and ext4 tracepoints, and jbd2 probe module.
> > 
> > -ECANTBUILD
> > 
> 
> Hi Kosaki,
> 
> Thanks for the report. This should be fixed in LTTng 0.78 now.
> 
> Best regards,

Unfortunately, lockdep part also can't build.

==
Subject: [PATCH] fix lockdep tracing build error

commit 6afe40b4dace385d7ba2faf24b352f066f3b71bf rename argument a0 to ip.
it cause following build error to lttng tree.

  CC      kernel/lockdep.o
kernel/lockdep.c: In function 'trace_hardirqs_on_caller':
kernel/lockdep.c:2186: error: 'a0' undeclared (first use in this function)
kernel/lockdep.c:2186: error: (Each undeclared identifier is reported only once
kernel/lockdep.c:2186: error: for each function it appears in.)
kernel/lockdep.c: In function 'trace_hardirqs_off_caller':
kernel/lockdep.c:2241: error: 'a0' undeclared (first use in this function)
make[1]: *** [kernel/lockdep.o] Error 1


therefore we also need change trace argument.


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
---
 kernel/lockdep.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index 2ec98a3..21ef2ad 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -2183,7 +2183,7 @@ void trace_hardirqs_on_caller(unsigned long ip)
 
 	time_hardirqs_on(CALLER_ADDR0, ip);
 
-	_trace_lockdep_hardirqs_on(a0);
+	_trace_lockdep_hardirqs_on(ip);
 
 	if (unlikely(!debug_locks || current->lockdep_recursion))
 		return;
@@ -2238,7 +2238,7 @@ void trace_hardirqs_off_caller(unsigned long ip)
 
 	time_hardirqs_off(CALLER_ADDR0, ip);
 
-	_trace_lockdep_hardirqs_off(a0);
+	_trace_lockdep_hardirqs_off(ip);
 
 	if (unlikely(!debug_locks || current->lockdep_recursion))
 		return;
-- 
1.6.0.6







--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/