linux-kernel - Re: [PATCH v2] sched: fix build error in kernel/sched_rt.c when RT_GROUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1231930476.7141.27.camel@twins>
Date:	Wed, 14 Jan 2009 11:54:36 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Gregory Haskins <ghaskins@...ell.com>, rostedt@...e.goodmis.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] sched: fix build error in kernel/sched_rt.c when
 RT_GROUP_SCHED && !SMP

On Wed, 2009-01-14 at 09:01 +0100, Ingo Molnar wrote:
> * Gregory Haskins <ghaskins@...ell.com> wrote:
> 
> > +#define dec_rt_group(rt_se, rt_rq) do { } while (0)
> 
> Please dont _ever_ introduce new CPP macros into core kernel code, and if 
> you see existing once, please fix them to be proper C inline functions. 
> (there's a few other new macros in your patchset)

Generally good advice, and certainly doable in this case. But in some
very rare occasions I've had to use CPP in order to avoid silly header
dependency hell -- I think we should add comments in such cases as to
why we use CPP.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/