linux-kernel - Re: [PATCH] sys_waitid: return -EFAULT for NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0901131655040.6528@localhost.localdomain>
Date:	Tue, 13 Jan 2009 16:57:55 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	mtk.manpages@...il.com
cc:	Roland McGrath <roland@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	kernel list <linux-kernel@...r.kernel.org>,
	Ulrich Drepper <drepper@...hat.com>,
	Vegard Nossum <vegard.nossum@...il.com>,
	"linux-man@...r.kernel.org" <linux-man@...r.kernel.org>
Subject: Re: [PATCH] sys_waitid: return -EFAULT for NULL



On Wed, 14 Jan 2009, Michael Kerrisk wrote:
> 
> It has zero downside for *us*.  But it is yet another example of Linux
> littering the Unix landscape with unnecessary inconsistencies that
> application writers must deal with.

Bah. Not so. It matters not at all if you try to write portable code. 

Linux has extensions. Deal with it. We have literally _thousands_ of 
things that work on Linux but not on other OS's. The fact is, you can't 
just recompile and assume something works, and waitid() has absolutely 
nothing to do with it.

> Well, POSIX.1-2001 is fairly clear:
> 
>       The  application shall ensure that the infop argument points to
>       a siginfo_t structure.

Right. So the application should do that, and Linux does the right thing. 
Problem solved.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/