linux-kernel - Re: checkpatch confused by pre-existing #endif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090114164539.GD10653@shadowen.org>
Date:	Wed, 14 Jan 2009 16:45:39 +0000
From:	Andy Whitcroft <apw@...onical.com>
To:	Pavel Roskin <proski@....org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: checkpatch confused by pre-existing #endif

On Tue, Jan 13, 2009 at 04:57:43PM -0500, Pavel Roskin wrote:
> Hello!
> 
> This patch confuses checkpatch.pl from Linux 2.6.29-rc1:
> 
> ====================
> --- foo.h.old	2009-01-13 16:48:22.000000000 -0500
> +++ foo.h	2009-01-13 16:48:18.000000000 -0500
> @@ -3,4 +3,8 @@
>  
>  
>  
> +#ifdef FOOBAR
> +#define foo
> +#endif
> +
>  #endif /* FOO_H */
> ====================
> 
> $ scripts/checkpatch.pl foo.diff 
> Can't use an undefined value as an ARRAY reference at
> scripts/checkpatch.pl line 453.
> 
> Apparently, the last #endif causes some data to be popped from the stack
> for preprocessor directives.  However, the corresponding #ifdef is
> outside the patch, so this fails.

Yes this should be fixed in the changes pushed up to Andrew.  You can
confirm this using the version here:

  http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/