linux-kernel - Re: [PATCH] x86: arch_probe_nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <496E4211.6040503@sgi.com>
Date:	Wed, 14 Jan 2009 11:50:41 -0800
From:	Mike Travis <travis@....com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Yinghai Lu <yinghai@...nel.org>, "H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: arch_probe_nr_irqs

Ingo Molnar wrote:
> * Mike Travis <travis@....com> wrote:
> 
>> Yinghai Lu wrote:
>>> Impact: save RAM with large NR_CPUS, get smaller nr_irqs
>>>
>>> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
>> Built and tested on an 8-core intel system.  Great reduction
>> in NR_IRQS:
>>
>> 	[    0.000000] NR_IRQS:33024 nr_irqs:320
>>
>> Thanks Yinghai!
>>
>> Ingo - shall I push this one as well?  (If not, then you
>> can add my:
>>
>> 	Acked-by: Mike Travis <travis@....com>
> 
> yes, please pick it up and i can pull it from you. Please also add a 
> longer changelog about the precise effects and perhaps some estimations 
> about what the before and after situation is, and perhaps also some bits 
> about how it affects normal Linux users as well.
> 
> 	Ingo

Hi Ingo,

Just so I don't screw this thing up, exactly what am I to 'pull' to fix
this error (listed at the end of this command sequence)?

Thanks,
Mike

    mkdir linux-2.6-cpus4096-for-ingo
    cd linux-2.6-cpus4096-for-ingo
    git-init-db
    git-remote add linus git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
    git-remote add tip git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git
    git-remote add my-cpus4096 git://git.kernel.org/pub/scm/linux/kernel/git/travis/linux-2.6-cpus4096-for-ingo.git
    git-remote add push-cpus4096 ssh://master.kernel.org/pub/scm/linux/kernel/git/travis/linux-2.6-cpus4096-for-ingo.git
    git-config --add remote.push-cpus4096.skipDefaultUpdate true
    git-remote update

    git-checkout -b edit-commits my-cpus4096/master
    git-log             # insure the commit is the last one
    git commit --amend

<edit changelog>

    git-push push-cpus4096 edit-commits:master

travis@...ter.kernel.org's password:
To ssh://master.kernel.org/pub/scm/linux/kernel/git/travis/linux-2.6-cpus4096-for-ingo.git
 ! [rejected]        edit-commits -> master (non-fast forward)
error: failed to push some refs to 'ssh://master.kernel.org/pub/scm/linux/kernel/git/travis/linux-2.6-cpus4096-for-ingo.git'

    git-push -f push-cpus4096 edit-commits:master

travis@...ter.kernel.org's password:
Counting objects: 31, done.
Compressing objects: 100% (4/4), done.
Writing objects: 100% (16/16), 1.97 KiB, done.
Total 16 (delta 14), reused 12 (delta 11)
error: denying non-fast forward refs/heads/master (you should pull first)
To ssh://master.kernel.org/pub/scm/linux/kernel/git/travis/linux-2.6-cpus4096-for-ingo.git
 ! [remote rejected] edit-commits -> master (non-fast forward)
error: failed to push some refs to 'ssh://master.kernel.org/pub/scm/linux/kernel/git/travis/linux-2.6-cpus4096-for-ingo.git'

=============================================================
Here is the altered commit message:

commit 939a9fc9e5f6fda4f797dea209fa881ce1368e37
Author: Yinghai Lu <yinghai@...nel.org>
Date:   Mon Jan 12 17:39:24 2009 -0800

    x86: arch_probe_nr_irqs

    Impact: save RAM with large NR_CPUS, get smaller nr_irqs

    Estimating NR_IRQS based on NR_CPUS results in excessive memory used for
    items like arrays sized by NR_IRQS.  This patch adds an arch specific
    'probe' or discovery routine to calculate the minimum number of slots
    required to handle the number of irqs on the running system.  The result
    is placed in the 'nr_irqs' variable.

    As an example, a system configured with NR_CPUS=4096 that has in fact
    8 cpu cores, results in a reduction from 33024 to 320 for the number of
    irqs required.  This is shown in a system log message:

        NR_IRQS:33024 nr_irqs:320

    Of course, this requires that other code dynamically allocate their irq
    arrays using nr_irqs instead of NR_IRQS.  An example is in early_irq_init()
    when CONFIG_SPARSE_IRQ is true.

    Currently, the only arch that has this probe function is x86.  A default
    weak arch_probe_nr_irqs function is placed in kernel/softirq.c, to avoid
    a problem with some gcc's that do not handle weak functions correctly,
    if they are in the same file as the reference.

    Signed-off-by: Yinghai Lu <yinghai@...nel.org>
    Signed-off-by: Mike Travis <travis@....com>




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/