linux-kernel - Re: linux-next: Tree for January 14 (multimedia/firesat-rc)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tkrat.7108b22625373d2e@s5r6.in-berlin.de>
Date:	Wed, 14 Jan 2009 23:01:56 +0100 (CET)
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Randy Dunlap <randy.dunlap@...cle.com>
cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Mauro Carvalho Chehab <mchehab@...radead.org>
Subject: Re: linux-next: Tree for January 14 (multimedia/firesat-rc)

Randy Dunlap wrote:
> drivers/built-in.o: In function `input_report_key':
> firesat-rc.c:(.text+0x776f3): undefined reference to `input_event'
> drivers/built-in.o: In function `firesat_register_rc':
> (.text+0x777af): undefined reference to `input_allocate_device'
> drivers/built-in.o: In function `firesat_register_rc':
> (.text+0x7781c): undefined reference to `input_register_device'
> drivers/built-in.o: In function `firesat_register_rc':
> (.text+0x77834): undefined reference to `input_free_device'
> drivers/built-in.o: In function `firesat_unregister_rc':
> (.text+0x7779d): undefined reference to `input_unregister_device'
> 
> config attached.
...
> # Input device support
> #
> # CONFIG_INPUT is not set

Thanks.  firesat a.k.a. firedtv lives currently in linux1394-2.6.git.


From: Stefan Richter <stefanr@...6.in-berlin.de>
Subject: firedtv: add missing dependency on CONFIG_INPUT

Fix build error \
Reported-by: Randy Dunlap <randy.dunlap@...cle.com>

Perhaps we should make the remote control part of firedtv modular so
that the driver can be built without input support.  But it's not very
likely that anybody would have use for such a constellation.

Signed-off-by: Stefan Richter <stefanr@...6.in-berlin.de>
---

I need to fold it into "DVB: add firesat driver" before I submit the
driver for mainline merge.

 drivers/media/dvb/firesat/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/media/dvb/firesat/Kconfig
===================================================================
--- linux.orig/drivers/media/dvb/firesat/Kconfig
+++ linux/drivers/media/dvb/firesat/Kconfig
@@ -1,6 +1,6 @@
 config DVB_FIREDTV
 	tristate "FireDTV (FireWire attached DVB receivers)"
-	depends on DVB_CORE && IEEE1394
+	depends on DVB_CORE && IEEE1394 && INPUT
 	help
 	  Support for DVB receivers from Digital Everywhere, known as FireDTV
 	  and FloppyDTV, which are connected via IEEE 1394 (FireWire).


-- 
Stefan Richter
-=====-==--= ---= -===-
http://arcgraph.de/sr/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/