linux-kernel - Re: [patch 3/5] x86: headers cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <496E6585.8050505@zytor.com>
Date:	Wed, 14 Jan 2009 14:21:57 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Cyrill Gorcunov <gorcunov@...il.com>,
	Markus Metzger <markus.t.metzger@...el.com>
CC:	mingo@...e.hu, linux-kernel@...r.kernel.org,
	harvey.harrison@...il.com, sam@...nborg.org,
	jaswinderrajput@...il.com, Cyrill Gorcunov <gorcunov@...nvz.org>
Subject: Re: [patch 3/5] x86: headers cleanup - ptrace-abi.h

Okay, this one really looks wrong to me.

Markus, could you confirm if this was ever intended to be exported to 
userspace?  I suspect The Right Thing is simply to remove the #ifdef 
CONFIG_X86_TRACE_BTS here...

	-hpa


Cyrill Gorcunov wrote:
> Impact: cleanup
> 
> 'make headers_check' warn us about leaking of kernel private
> (mostly compile time vars) data to userspace in headers. Fix it.
> 
> ptrace_bts_config struct is wrapped by __KERNEL__ --
> not sure if it was ever proposed for userland. On the
> other hand branch tracing is really anxious for userland
> developers.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
> ---
>  arch/x86/include/asm/ptrace-abi.h |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Index: linux-2.6.git/arch/x86/include/asm/ptrace-abi.h
> ===================================================================
> --- linux-2.6.git.orig/arch/x86/include/asm/ptrace-abi.h
> +++ linux-2.6.git/arch/x86/include/asm/ptrace-abi.h
> @@ -50,7 +50,7 @@
>  #define RSP 152
>  #define SS 160
>  #define ARGOFFSET R11
> -#endif /* __ASSEMBLY__ */
> +#endif /* __ASSEMBLY__ || __FRAME_OFFSETS */
>  
>  /* top of stack page */
>  #define FRAME_SIZE 168
> @@ -80,6 +80,7 @@
>  
>  #define PTRACE_SINGLEBLOCK	33	/* resume execution until next branch */
>  
> +#ifdef __KERNEL__
>  #ifdef CONFIG_X86_PTRACE_BTS
>  
>  #ifndef __ASSEMBLY__
> @@ -141,5 +142,6 @@ struct ptrace_bts_config {
>     Returns number of BTS records drained.
>  */
>  #endif /* CONFIG_X86_PTRACE_BTS */
> +#endif /* __KERNEL__ */
>  
>  #endif /* _ASM_X86_PTRACE_ABI_H */
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/