linux-kernel - [PATCH] drm/i915: why does kconfig hate?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1231973292-8344-1-git-send-email-eric@anholt.net>
Date:	Wed, 14 Jan 2009 14:48:12 -0800
From:	Eric Anholt <eric@...olt.net>
To:	linux-kernel@...r.kernel.org
Cc:	Eric Anholt <eric@...olt.net>
Subject: [PATCH] drm/i915: why does kconfig hate?

This is the obvious fix attempt for people updating their .configs and not
getting the i915 driver any more, or people not selecting FB and not finding
it as an option.  We want to just enable the code needed to build the driver,
not force the user to go find the option to enable it, because they really
don't care.

However, with this patch, the build results in:
drivers/gpu/drm/Kconfig:8:error: found recursive dependency: DRM -> <choice> -> DRM_I915 -> FB -> FB_I810 -> AGP -> DRM
and I need some help interpreting this.  In particular, how do these two
dependencies get produced:
FB -> FB_I810
AGP -> DRM
as they seem to be backwards (DRM results in AGP being required, FB_I810
results in FB being required).  If I remove this wonky bit from DRM:

 menuconfig DRM
        tristate "Direct Rendering Manager (XFree86 4.1.0 and higher DRI support
-       depends on (AGP || AGP=n) && PCI && !EMULATED_CMPXCHG && MMU
+       depends on PCI && !EMULATED_CMPXCHG && MMU

then it still produces:
drivers/video/Kconfig:23:error: found recursive dependency: FB -> FB_I810 -> AGP -> <choice> -> DRM_I915 -> FB
---
 drivers/gpu/drm/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 5130b72..4be3acb 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -70,7 +70,7 @@ config DRM_I915
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
-	depends on FB
+	select FB
 	tristate "i915 driver"
 	help
 	  Choose this option if you have a system that has Intel 830M, 845G,
-- 
1.5.6.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/