linux-kernel - Re: [PATCH 0/10] MAINTAINERS - script, patterns, and misc fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1231904942.7935.486.camel@localhost>
Date:	Tue, 13 Jan 2009 19:49:02 -0800
From:	Joe Perches <joe@...ches.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	torvalds@...ux-foundation.org, pavel@....cz,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/10] MAINTAINERS - script, patterns, and misc fixes

On Tue, 2009-01-13 at 12:54 -0800, Andrew Morton wrote:
> I applaud the intent.
> This patchset is basically unmergeable by anyone except Linus - it
> already gets three rejects against half-hour-old mainline.

True.

> How does it work, anyway?

Find a section/file match by pattern.
If --git set (default), find the git "by: " signees by file.
It uses the equivalent of what Linus posted quite a while back.

+sub recent_git_signoffs {
+    my ($file) = @_;
+
+    my $sign_offs = "";
+    my $cmd = "";
+    my $output = "";
+
+    my @lines = ();
+
+    if (which("git") eq "") {
+       die("$P: git not found.  Add --nogit to options?\n");
+    }
+
+    $cmd = "git log --since=12.months.ago -- ${file}";
+    $cmd .= " | grep -i '^    [-a-z]*by:.*\\\@'";
+    if (!$email_git_penguin_chiefs) {
+       $cmd .= " | grep -E -v \"${penguin_chiefs}\"";
+    }
+    $cmd .= " | sort | uniq -c | sort -r -n | head -n 5";
+    $cmd .= " | cut -f 2 -d ':' -s";


> akpm:/usr/src/git26> ../25/scripts/get_maintainer.pl -f mm/filemap.c 
> Balbir Singh <balbir@...ux.vnet.ibm.com>
> Hugh Dickins <hugh@...itas.com>
> KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> Miklos Szeredi <mszeredi@...e.cz>
> Nick Piggin <npiggin@...e.de>
> 
> I think Balbir would be surprised!

$ scripts/get_maintainer.pl --nogit -f mm/filemap.c
linux-kernel@...r.kernel.org
linux-mm@...ck.org

> akpm:/usr/src/git26> ../25/scripts/get_maintainer.pl -f fs/ext3/super.c
> Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com>
> Christoph Hellwig <hch@....de>
> Jan Blunck <jblunck@...e.de>
> Jan Kara <jack@...e.cz>
> Marcin Slusarz <marcin.slusarz@...il.com>
> 
> mm..  spose so, but it isn't terribly accurate.  Does it take
> signed-off-by:s and/or the git Commit: header into account?

Just the most frequent and top 5 "by:" signees for the last year.

$ scripts/get_maintainer.pl --nogit -f fs/ext3/super.c
Andreas Dilger <adilger@....com>
Andrew Morton <akpm@...ux-foundation.org>
Stephen Tweedie <sct@...hat.com>
linux-ext4@...r.kernel.org

> akpm:/usr/src/git26> ../25/scripts/get_maintainer.pl -f fs/xfs/xfs.h   
> Christoph Hellwig <hch@...radead.org>
> Donald Douwsma <donaldd@....com>
> Eric Sandeen <sandeen@...deen.net>
> Lachlan McIlroy <lachlan@....com>
> Tim Shimmin <tes@....com>
> 
> OK, that was an easy case.

$ scripts/get_maintainer.pl --nogit -f fs/xfs/xfs.h
Tim Shimmin <xfs-masters@....sgi.com>
xfs@....sgi.com


> It's a bit slow.  That's git's fault.  Perhaps some git person will be
> able to suggest ways of speeding it up.

Don't use git?  Add --nogit?

> akpm:/usr/src/git26> ../25/scripts/get_maintainer.pl -f mm/pdflush.c 
> Ingo Molnar <mingo@...e.hu>
> Jesper Juhl <jesper.juhl@...il.com>
> Mike Travis <travis@....com>
> OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
> Pavel Machek <pavel@...e.cz>
> 
> again, not the result I'd have expected!

$ scripts/get_maintainer.pl --nogit -f mm/pdflush.c 
linux-kernel@...r.kernel.org
linux-mm@...ck.org

> But I guess we can fine-tune these thnigs after we get the bulk of it
> settled in.
> My script generates what I consider to be better results:

[script...]

I have no problem changing the get_maintainer.pl script to use
only the "author:" instead of the signees.

My desire is to add the file patterns themselves.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/