linux-kernel - Re: [PATCH 2.6.29-rc1-git4] mfd: da9030 usb charge pump support within mfd driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f17812d70901142302n53953607o124df5601cd037bc@mail.gmail.com>
Date:	Thu, 15 Jan 2009 15:02:05 +0800
From:	Eric Miao <eric.y.miao@...il.com>
To:	Mike Rapoport <mike@...pulab.co.il>
Cc:	Jonathan Cameron <jic23@....ac.uk>,
	LKML <linux-kernel@...r.kernel.org>,
	Mark Brown <broonie@...ena.org.uk>,
	Samuel Ortiz <sameo@...nedhand.com>, felipe.balbi@...ia.com,
	Liam Girdwood <lrg@...nel.org>
Subject: Re: [PATCH 2.6.29-rc1-git4] mfd: da9030 usb charge pump support 
	within mfd driver.

On Thu, Jan 15, 2009 at 2:34 PM, Mike Rapoport <mike@...pulab.co.il> wrote:
>
>
> Eric Miao wrote:
>> On Thu, Jan 15, 2009 at 2:16 AM, Jonathan Cameron <jic23@....ac.uk> wrote:
>>> From: Jonathan Cameron <jic23@....ac.uk>
>>>
>>> Add support for changing the mode of the da9030 usb charge pump
>>>
>>
>> Well, if it is totally USB charger related, I'd suggest to move this into
>> the dedicated driver. This mfd/da903x.c serves as a common code
>> base for all sub-peripherals.
>
> It's not exactly related to the charger, it's rather related to the USB voltage
> supplied to USB devices attached to PXA OHCI.
> Indeed the mfd/da903x.c serves as a common core for sub-peripherals, but IMHO
> adding a subdevice driver because of single method doesn't worth the overhead.
> I'm for the solution Jonathan proposes.
>

Mmm... then who will be the invoker? I'm a bit upset about this
being exported while called out of control. If it works as the
name suggested, setting some mode, maybe we can have a
platform data field specifying this, and hide this totally within
the driver. I didn't look into this too much, just a concern here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/