[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090115084110.GB9032@localhost>
Date: Thu, 15 Jan 2009 11:41:10 +0300
From: Cyrill Gorcunov <gorcunov@...il.com>
To: "Metzger, Markus T" <markus.t.metzger@...el.com>
Cc: "H. Peter Anvin" <hpa@...or.com>, "mingo@...e.hu" <mingo@...e.hu>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"harvey.harrison@...il.com" <harvey.harrison@...il.com>,
"sam@...nborg.org" <sam@...nborg.org>,
"jaswinderrajput@...il.com" <jaswinderrajput@...il.com>
Subject: Re: [patch 3/5] x86: headers cleanup - ptrace-abi.h
[Metzger, Markus T - Thu, Jan 15, 2009 at 08:06:31AM +0000]
| >-----Original Message-----
| >From: H. Peter Anvin [mailto:hpa@...or.com]
| >Sent: Wednesday, January 14, 2009 11:22 PM
| >To: Cyrill Gorcunov; Metzger, Markus T
| >Cc: mingo@...e.hu; linux-kernel@...r.kernel.org; harvey.harrison@...il.com; sam@...nborg.org;
| >jaswinderrajput@...il.com; Cyrill Gorcunov
| >Subject: Re: [patch 3/5] x86: headers cleanup - ptrace-abi.h
| >
| >Okay, this one really looks wrong to me.
| >
| >Markus, could you confirm if this was ever intended to be exported to
| >userspace? I suspect The Right Thing is simply to remove the #ifdef
| >CONFIG_X86_TRACE_BTS here...
|
| This is intended for userspace.
| I added the #ifdef so the entire feature could be turned off.
| This might not be necessary for declarations and macros, though.
|
| Do you want me to remove the #ifdef CONFIG around the declarations in ptrace headers?
|
| regards,
| markus.
Hi Markus,
since it's supposed to be visible by userspace then we
should just remove this CONFIG_X86_PTRACE_BTS so if userspace
app has a reference to ptrace_bts_config but kernel in turn has
this feature turned off -- the uerspace app shouldn't fail
while being compiling.
| >
| > -hpa
| >
| >
...
- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists