[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20090115092352.5d2ceffd@infradead.org>
Date: Thu, 15 Jan 2009 09:23:52 +0000
From: Arjan van de Ven <arjan@...radead.org>
To: Nigel Cunningham <ncunningham@...a.org.au>
Cc: "Rafael J. Wysocki" <rjw@...k.pl>,
Andrew Morton <akpm@...ux-foundation.org>, pavel@...e.cz,
linux-pm@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [linux-pm] [PATCH] resume: wait for device probing to finish
On Thu, 15 Jan 2009 12:34:36 +1100
Nigel Cunningham <ncunningham@...a.org.au> wrote:
> Hi Rafael etc.
>
> On Thu, 2009-01-15 at 00:39 +0100, Rafael J. Wysocki wrote:
>
> [...]
>
> > /**
> > + * wait_for_device_probe
> > + * Wait for device probing to be completed.
> > + *
> > + * Note: this function polls at 100 msec intervals.
> > + */
> > +int wait_for_device_probe(void)
> > +{
> > + /* wait for the known devices to complete their probing */
> > + while (driver_probe_done() != 0)
> > + msleep(100);
> > + async_synchronize_full();
> > + return 0;
> > +}
> > +
>
> Am I missing something? I can't see why you're polling instead of
> using probe_waitqueue.
I'm just consolidating the existing code to one place.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists