linux-kernel - [mmotm][PATCH] fix ia64 build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090115200315.EBE3.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Date:	Thu, 15 Jan 2009 20:05:08 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	LKML <linux-kernel@...r.kernel.org>,
	linux-ia64 <linux-ia64@...r.kernel.org>,
	Sam Ravnborg <sam@...nborg.org>,
	Kyle McMartin <kyle@...artin.ca>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tony Luck <tony.luck@...el.com>
Cc:	kosaki.motohiro@...fujitsu.com
Subject: [mmotm][PATCH] fix ia64 build error


Applied after: linux-next.patch
==
Subject: [PATCH] remove duplicate EXPORT_SYMBOL()
Impact: fix build error

In past, ia64_ksyms.c had EXPORT_SYMBOL(copy_page) in wrong place.

old code was

	#include <asm/uaccess.h>
	EXPORT_SYMBOL(__copy_user);
	EXPORT_SYMBOL(__do_clear_user);
	EXPORT_SYMBOL(__strlen_user);
	EXPORT_SYMBOL(__strncpy_from_user);
	EXPORT_SYMBOL(__strnlen_user);
	EXPORT_SYMBOL(copy_page);

(but actually, copy_page is declared in asm/page.h)

And recently, commit bdc2619ab95d45d434c16d5c216bc6243761f6fb insert
EXPORT_SYMBOL(copy_page) into correct place.

then, duplicate EXPORT_SYMBOL create following build error.

arch/ia64/kernel/ia64_ksyms.c:65: error: redefinition of '__kcrctab_copy_page'
arch/ia64/kernel/ia64_ksyms.c:43: error: previous definition of '__kcrctab_copy_page' was here
arch/ia64/kernel/ia64_ksyms.c:65: error: redefinition of '__kstrtab_copy_page'
arch/ia64/kernel/ia64_ksyms.c:43: error: previous definition of '__kstrtab_copy_page' was here
arch/ia64/kernel/ia64_ksyms.c:65: error: redefinition of '__ksymtab_copy_page'
arch/ia64/kernel/ia64_ksyms.c:43: error: previous definition of '__ksymtab_copy_page' was here


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc: Sam Ravnborg <sam@...nborg.org>
Cc: Kyle McMartin <kyle@...artin.ca>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Tony Luck <tony.luck@...el.com>
---
 arch/ia64/kernel/ia64_ksyms.c |    1 -
 1 file changed, 1 deletion(-)

Index: b/arch/ia64/kernel/ia64_ksyms.c
===================================================================
--- a/arch/ia64/kernel/ia64_ksyms.c
+++ b/arch/ia64/kernel/ia64_ksyms.c
@@ -40,7 +40,6 @@ EXPORT_SYMBOL(__do_clear_user);
 EXPORT_SYMBOL(__strlen_user);
 EXPORT_SYMBOL(__strncpy_from_user);
 EXPORT_SYMBOL(__strnlen_user);
-EXPORT_SYMBOL(copy_page);
 
 /* from arch/ia64/lib */
 extern void __divsi3(void);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/